[PATCH] ld/testsuite: handle Windows drive letter in persistent section

[Clément Chigot]

On Tue, Feb 21, 2023 at 10:25 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 21.02.2023 10:03, Clément Chigot via Binutils wrote:
> > --- a/ld/testsuite/ld-elf/persistent-sections-2.l
> > +++ b/ld/testsuite/ld-elf/persistent-sections-2.l
> > @@ -1,5 +1,5 @@
> >  #...
> > -[^:]*: warning: orphan section `.persistent.var_persistent' from \S+ being placed in section `.persistent.var_persistent'
> > +(|.:)[^:]*: warning: orphan section `.persistent.var_persistent' from \S+ being placed in section `.persistent.var_persistent'
> >  #...
> > -[^:]*: warning: orphan section `.gnu.linkonce.p.var_persistent2' from \S+ being placed in section `.gnu.linkonce.p.var_persistent2'
> > +(|.:)[^:]*: warning: orphan section `.gnu.linkonce.p.var_persistent2' from \S+ being placed in section `.gnu.linkonce.p.var_persistent2'
>
> Personally I find "(|.:)" slightly less intuitive than "(.:)?", so could
> I maybe talk you into using the alternative form?
>
> However, seeing your further reply (mainly targeted at Alan) I also
> wonder whether the issue can't be addressed in a more general manner, by
> pruning drive letters from diagnostics before actually doing any regexp
> matching. Such pruning could then also be limited to actually running on
> Windows, whereas changing expectations in test cases would affect all
> targets.

For the record, I have pushed "testsuite: prune DOS drive letter in
test outputs", implementing Jan's idea.

Clément