[PATCH v4 5/5] Calculate CRC64 over the .text area
Nick Clifton
nickc@redhat.com
Tue Feb 21 13:26:40 GMT 2023
Hi Ulf,
Please try to follow the GNU Coding standards when writing
new code:
https://www.gnu.org/prep/standards/
Having a consistent style greatly improves the readability
of the code.
> + einfo (_("%P:%pS: warning: Only the first CRC polynome is used\n"),
> + NULL);
Is there a particular reason why multiple CRC polynomes are not supported ?
> + for (bfd_vma i = 0 ; i < 256 ; i++)
You could just use an integer for this loop....
> + /*
> + * Get the '.text' section
> + * Is there a risk that CRC needs to be calculated on more than .text?
> + * We do not support that...
You definitely should.
I think that I will save a full review of this code until the formatting is
fixed up.
Cheers
Nick
More information about the Binutils
mailing list