[PATCH 1/4] gas/testsuite: adjust a test for case insensitive file systems

Jan Beulich jbeulich@suse.com
Tue Feb 21 08:40:55 GMT 2023


On 20.02.2023 09:22, Clément Chigot via Binutils wrote:
> When dealing with case insensitive file systems, ".file line.s" and
> ".file Line.s" are identical and thus gas won't change the current
> input file.
> However, in line.l test, it's expecting to trigger an input file switch.
> As the second filename doesn't matter in it, change it to fit for those
> file systems.
> 
> gas/ChangeLog:
> 
> 	* testsuite/gas/elf/line.l: Change Line.s to new_line.s.

Since I have a pretty sincere dislike for underscores in filenames, may
I ask that you use e.g. line2.s or even (preserving original case)
Line2.s? Other than that I'm okay with the change, albeit I'd like to
point out that libiberty's filename_cmp() isn't really international-
ready (works reliably only for ASCII), and hence there are apparently
bigger issues here. Plus file system properties cannot really be a build-
time constraint, as there could be a mix that is in use.

Jan


More information about the Binutils mailing list