Should we require GNU make in binutils?

Alan Modra amodra@gmail.com
Fri Aug 25 03:23:29 GMT 2023


I see the toplevel Makefile.in makes use of $(filter-out ..) and other
GNU Make extensions, and requires GNU Make 3.80 or later when building
gcc.  gdb also uses GNU make extensions.  It seems silly to me that
binutils is still trying to avoid GNU make extensions.

We could start with the following (originally from Hans-Peter) which
avoids a whole lot of entering/leaving messages when building with
--enable-targets=all.  What do people think?

diff --git a/ld/Makefile.am b/ld/Makefile.am
index be456275748..fcb93060a14 100644
--- a/ld/Makefile.am
+++ b/ld/Makefile.am
@@ -633,19 +633,10 @@ GEN_DEPENDS = $(srcdir)/genscripts.sh stringify.sed
 
 @TDIRS@
 
-# We can't use pattern rules as we don't want to depend on GNU
-# make, or else these rules could have been expressed in one
-# two-liner: 'e%.c:' and '	${GENSCRIPTS} $* "$(tdir_$*)"'.
-# (The recursive variable expansion is portable.)
-
-run-genscripts:
-	$(AM_V_at)${GENSCRIPTS} $(script_target) "$($(script_tdirname))"
-
-.PHONY: run-genscripts
+e%.c:
+	$(AM_V_GEN)${GENSCRIPTS} $* "$(tdir_$*)"
 
 $(ALL_EMULATION_SOURCES) $(ALL_64_EMULATION_SOURCES): $(GEN_DEPENDS)
-	$(AM_V_GEN)base=`echo $@ | sed -e 's,e\(.*\).c,\1,'`; \
-	$(MAKE) run-genscripts "script_target=$$base" "script_tdirname=tdir_$$base"
 
 # It's a pity we can't generate these include "./deps/e*.Pc" lines
 # from ALL_EMULATION_SOURCES and ALL_64_EMULATION_SOURCES, but that isn't

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list