[PATCH v4 7/7] MIPS: Fix Irix gas testcases
Maciej W. Rozycki
macro@orcam.me.uk
Tue Aug 15 10:14:35 GMT 2023
On Tue, 15 Aug 2023, Jan Beulich wrote:
> >> 1. Add -mpdr to some cases.
> >> Gas doesn't generate .pdr section for Irix objects by default. See
> >> `int mips_flag_pdr` in tc-mips.c.
> >>
> >> 2. Add irix-no-pdr.d.
> >>
> >> 3. Add and use call-nonpic-1-irix.d for Irix targets.
> >> Gas doesn't set O32 flags for Irix objects in e_flags. See
> >> `use_e_mips_abi_o32` in gas/configure.ac.
> >>
> >> 4. Add mips16-e-irix.d: g1 is marked as O on Irix.
> >> The Irix 5 and 6 assemblers set the type of any common symbol and
> >> any undefined non-function symbol to STT_OBJECT.
> >> See `mips_frob_symbol` in tc-mips.c.
> >
> > @Maciej W. Rozycki ping.
>
> >From what I can tell, you've addressed all of Maciej's comments on v1.
> On that basis this patch is provisionally approved in case he or
> Chenghua don't respond within another two weeks time. Btw., it often
> helps to send pings To: the person(s) pinged, not just Cc-ing them.
This was sent as a part of a patch set that has been superseded by later
changes. How do I know it is still relevant? It is the responsibility of
the submitter to track changes in the tree and ping and/or resubmit as
required.
In this case four different classes of changes have been grouped into a
single change, as listed in the change description, so this has to be
split accordingly into four self-contained patches before I can consider
it.
Maciej
More information about the Binutils
mailing list