[REVIEW ONLY 4/4] RISC-V: Tentative ".bfloat16" assembly support

Tsukasa OI research_trasio@irq.a4lg.com
Thu Aug 3 07:17:47 GMT 2023



On 2023/08/03 15:47, Jan Beulich wrote:
> On 03.08.2023 02:04, Tsukasa OI via Binutils wrote:> --- a/gas/config/tc-riscv.c
>> +++ b/gas/config/tc-riscv.c
>> @@ -437,7 +437,7 @@ const char EXP_CHARS[] = "eE";
>>  
>>  /* Chars that mean this number is a floating point constant.
>>     As in 0f12.456 or 0d1.2345e12.  */
>> -const char FLT_CHARS[] = "rRsSfFdDxXpPhH";
>> +const char FLT_CHARS[] = "rRsSfFdDxXpPhHb";
> 
> I realize Arm64 also has it this way (x86 doesn't), but are you sure
> about only adding 'b' and not also 'B'? Aiui this introduces a needless
> special case of case sensitivity.
> 
> Jan
> 

I'm not sure (the only reason I did so is because what I saw is AArch64
code).  So, I'll investigate whether introducing additional character
will benefit (I think there's not so many cases but there might be at
least one).

Tsukasa


More information about the Binutils mailing list