[PATCH] MIPS: add MT ASE support for micromips32

YunQiang Su syq@debian.org
Tue Apr 25 10:20:21 GMT 2023


Maciej W. Rozycki <macro@orcam.me.uk> 于2023年4月25日周二 18:03写道:
>
> On Tue, 25 Apr 2023, YunQiang Su wrote:
>
> > diff --git a/opcodes/micromips-opc.c b/opcodes/micromips-opc.c
> > index 94812a68c82..5a6460d9b8b 100644
> > --- a/opcodes/micromips-opc.c
> > +++ b/opcodes/micromips-opc.c
> > @@ -148,6 +148,10 @@ decode_micromips_operand (const char *p)
> >      case '~': SINT (12, 0);
> >      case '@': SINT (10, 16);
> >      case '^': HINT (5, 11);
> > +    case '*': REG (2, 23, ACC);
> > +    case '!': UINT (1, 10);
> > +    case '$': UINT (1, 9);
> > +    case '&': REG (2, 18, ACC);
> >
> >      case '0': SINT (6, 16);
> >      case '1': HINT (5, 16);
> > @@ -165,6 +169,7 @@ decode_micromips_operand (const char *p)
> >      case 'G': REG (5, 16, COPRO);
> >      case 'K': REG (5, 16, HW);
> >      case 'H': UINT (3, 11);
> > +    case 'O': UINT (3, 4);
> >      case 'M': REG (3, 13, CCC);
> >      case 'N': REG (3, 18, CCC);
> >      case 'R': REG (5, 6, FP);
>
>  When adding new operand formats you need to document them in
> include/opcode/mips.h.  NB this is not a full review.
>
Thank you. Are these lines OK for it?

   DSP ASE usage:
   "*" 2-bit unsigned immediate in rt section for MFTR
   "&" 2-bit unsigned immediate in rs section for MTTR
   "!" 1-bit 'u' value in MFTR/MTTR
   "$" 1-bit 'h' value in MFTR/MTTR
   "O" 3-bit 'sel' value in MFTR/MTTR

I will add this comment in the next revision, with more fixes if any.

>   Maciej


More information about the Binutils mailing list