[RFC] ld/testsuite: force warnings when dealing with execstack tests
Nick Clifton
nickc@redhat.com
Wed Sep 28 14:05:15 GMT 2022
Hi Clément,
> * testsuite/ld-elf/elf.exp (PR ld/29072): Force execstack and
> RWD segment warnings.
I like this patch - simplifying things is always a good idea in my opinion.
One suggestion though:
> run_ld_link_tests [list \
> [list "PR ld/29072 (warn about an executable .note.GNU-stack)" \
> - "-e 0 $extra_link_opts" \
> + "-e 0 --warn-execstack --warn-rwx-segments" \
> "" \
> "" \
> {pr29072-a.s} \
I would add a comment explaining why the two options are always used here.
Just in case a future reader thinks that they are redundant and submits a
patch to remove them. :-)
Cheers
Nick
More information about the Binutils
mailing list