[PATCH 1/1] gold: Suppress "unused" variable warning on Clang

Tsukasa OI research_trasio@irq.a4lg.com
Mon Sep 26 10:35:40 GMT 2022


Clang generates a warning if there is a variable that is set but not used
otherwise ("-Wunused-but-set-variable").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

Because the cause of this error is in the Bison-generated code
($(srcdir)/gold/yyscript.y -> $(builddir)/gold/yyscript.c),
this commit suppresses this warning ("-Wunused-but-set-variable") by placing
DIAGNOSTIC_IGNORE_UNUSED_BUT_SET_VARIABLE macro at the end of user
prologue on yyscript.y.

gold/ChangeLog:

	* yyscript.y: Suppress -Wunused-but-set-variable warning on
	the Bison-generated code.
---
 gold/yyscript.y | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gold/yyscript.y b/gold/yyscript.y
index 909786f0ddd..fe8f6812712 100644
--- a/gold/yyscript.y
+++ b/gold/yyscript.y
@@ -26,6 +26,7 @@
 %{
 
 #include "config.h"
+#include "diagnostics.h"
 
 #include <stddef.h>
 #include <stdint.h>
@@ -34,6 +35,8 @@
 
 #include "script-c.h"
 
+DIAGNOSTIC_IGNORE_UNUSED_BUT_SET_VARIABLE
+
 %}
 
 /* We need to use a pure parser because we might be multi-threaded.
-- 
2.34.1



More information about the Binutils mailing list