[PATCH 1/2] i386: Add <Vxy> and <Exy>

H.J. Lu hjl.tools@gmail.com
Mon Oct 31 16:30:29 GMT 2022


On Mon, Oct 31, 2022 at 2:04 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 31.10.2022 07:06, Haochen Jiang wrote:
> > From: konglin1 <lingling.kong@intel.com>
> >
> > opcodes/
> >             * i386-opc.tbl: Add <Vxy> for VEX insn with x/y suffix,
> >           and <Exy> for EVEX insn with x/y suffix.
>
> Code change looks good (and thanks for splitting it off), but the changelog
> entry wants to use "rename" instead of "add", not the least to also mention

Agreed.

> the identifier which goes away. However, this kind of a change is where
> personally I think the legacy changelog model is quite a bit worse than
> the modern one with a proper textual commit message.
>

I prefer concise and accurate ChangeLog entries.  It is easier to tell
what the changes are.

-- 
H.J.


More information about the Binutils mailing list