[PATCH,V3 11/15] libctf: add libsframe to LDFLAGS and LIBS

[Mike Frysinger]

On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote:
> --- a/libctf/configure.ac
> +++ b/libctf/configure.ac
>
> -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
> +LDFLAGS="-L../bfd -L../libiberty -L../libsframe/.libs/ $ZLIBDIR $LDFLAGS"

libbfd is using libtool which generates libbfd.la which should contain the
libsframe linking info, so do you really need this manual -L ?  and if you
really do, doesn't -L../libsframe suffice ?

> -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
> +LIBS="-lbfd -liberty -lz -lsframe $ZSTD_LIBS $intl $LIBS"

similarly here, the libbfd->libsframe dependency should be tracked by the
libtool linker script ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20221030/1f90246a/attachment.sig>