[PATCH]

[Jan Beulich]

On 28.10.2022 09:20, Joshi, Tejas Sanjay wrote:
> opcodes/
> 
> 	* i386-dis.c (x86_64_table): Add rmpquery.
> 	* i386-gen.c (cpu_flag_init): Add CPU_ZNVER4_FLAGS and CpuRMPQUERY.

You also (afaict needlessly) add CPU_RMPQUERY_FLAGS, whereas CpuRMPQUERY
isn't applicable here; you already ...

> 	(cpu_flags): Add CpuRMPQUERY.

... mention it here, where it is applicable.

> 	* i386-opc.h (enum): Add CpuRMPQUERY.
> 	(i386_cpu_flags): Add cpurmpquery.
> 	* i386-opc.tbl: Add rmpquery insn.

The three relevant SNP insn have a comment: "The single-operand forms
exist only for compatibility with older gas." Therefore I'd like to ask
that new insns (like the one you add here) don't have that strange form
also added.

Other than these looks largely okay to me.

Note that commenting on patches would be easier if they were (also)
sent inline, not (just) as attachment(s).

Jan