[PATCH 10/10] Support Intel PREFETCHI

Cui, Lili lili.cui@intel.com
Thu Oct 27 07:43:00 GMT 2022


> On 27.10.2022 09:01, Cui, Lili wrote:
> >>> -  /* Update operand types and check extended states.  */
> >>> +  /* 1. Update operand types and check extended states.
> >>> +     2. Check IP-relative addressing for prefetchi.  */
> >>>    for (j = 0; j < i.operands; j++)
> >>>      {
> >>> +      /* Check if IP-relative addressing requirements can be satisfied.  */
> >>> +      if (i.tm.cpu_flags.bitfield.cpuprefetchi
> >>> +	  && !(i.base_reg && i.base_reg->reg_num == RegIP))
> >>> +	as_warn (_("only support RIP-relative address"));
> >>
> >> One final suggestion:
> >>
> >> 	as_warn (_("`%s' only supports RIP-relative address"), i.tm.name);
> >>
> > Done.
> >
> >> And maybe also keep code and comment in sync as to the sequence of
> >> things done.
> >>
> > Changed, thanks Jan.
> 
> Thanks to you as well. I'd like to leave approving of the change to H.J., though.
> 
Ok.

> One final reminder: Please in the future send new versions of patches as
> new (roots of) mail threads, with an incremented version identifier. In
> particular when later looking for stuff, doing so often makes it easier to
> follow how things evolved before being committed.
> 
Good advice, I will follow it. Thanks.

Lili
> Jan


More information about the Binutils mailing list