[PATCH 10/10] Support Intel PREFETCHI

Jan Beulich jbeulich@suse.com
Tue Oct 25 15:41:47 GMT 2022


On 25.10.2022 15:03, Cui, Lili wrote:
>>> +    {
>>> +      if (ins->intel_syntax)
>>> +	ins->mnemonicendp = stpcpy (ins->obuf, "nop   ");
>>> +      else
>>> +	ins->mnemonicendp = stpcpy (ins->obuf, "nopl  ");
>>
>> Why "nopl"? There's no NP ahead of the opcode (and you also don't go
>> through prefix_table[]), so I expect operand size should be expressed here
>> correctly.
> I changed it to nop.

But that still doesn't correctly express operand size. It needs to
be nopl / nopq / nopw depending on operand size prefix and REX.W.
IOW no different than how this opcode would (hopefully) disassemble
before your change.

Jan


More information about the Binutils mailing list