[PATCH 15/40] sim/h8300: Add "+ 0x0" to avoid self-assignments

Jeff Law jeffreyalaw@gmail.com
Tue Oct 25 13:54:30 GMT 2022


On 10/20/22 03:26, Tsukasa OI via Binutils wrote:
> Clang generates a warning if there is a redundant self-assignment
> ("-Wself-assign").  On the default configuration, it causes a build failure
> (unless "--disable-werror" is specified).
>
> However, removing self-assignments in step_once function makes the code less
> readable.  Instead, this commit inserts dummy addition to match the comments
> "Value added == 0".  This is redundant but will suppress warnings and
> matches with other branches better.  It will be also optimized away so we
> can ignore performance impact on this.
> ---
>   sim/h8300/compile.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

OK.

jeff




More information about the Binutils mailing list