[PATCH 09/10] Support Intel AMX-FP16

Cui, Lili lili.cui@intel.com
Tue Oct 25 13:05:17 GMT 2022


> >>>> +  { "CPU_ANY_AMX_FP16_FLAGS",
> >>>> +    "CpuAMX_FP16" },
> >>>>  };
> >>>
> >>> Same here then.
> >> Done.
> >
> > I guess my comment here was a little misleading (I'm sorry for that),
> > in that in addition I was expecting you to consider the comment
> > regarding the need for the *_ANY_* constants that I did give for
> > several of the patches in this series. I think the question applies
> > here as well: Are there dependent features known to appear? If not,
> > there's no need for the extra constant.
> 
> I have to apologize and take back the _ANY_-related comment here (it
> applies in the other places I've explicitly given it for this series).
> It was only yesterday (in the course of automating the dependency recording
> as much as possible) that I realized that there's a two way requirement for
> re-using the non-ANY form in the initializer of the 3rd field of cpu_flags[]
> entries: There must not be dependents _and_ there must also not be
> dependencies. Otherwise disabling a feature (via command line option or
> directive) would also disable the feature's prereq ones. With my work to
> (mostly) automate this, I guess there's no strong need to patch this
> separately - there are many more issues that will need taking care of once
> the base logic is in place.
> 
Np. Do we need to change them back.

Lili.

> Jan


More information about the Binutils mailing list