[PATCH 03/10] Support Intel AVX-NE-CONVERT
Jan Beulich
jbeulich@suse.com
Tue Oct 25 06:44:31 GMT 2022
On 24.10.2022 07:59, Kong, Lingling wrote:
> Thanks you so much for reviewing this patch. I really appreciate it. For these review comments, I have made some changes.
I guess the conversion to Vxy / Exy would better have been a separate,
prereq patch.
Like for the earlier patches - maybe better move the insertion in
opcodes/i386-opc.tbl to immediately after the related, pre-existing
templates? Plus vcvtne*2ps are all still lacking CheckRegSize afaict.
And then within a group we usually strive to sort alphabetically
when no other, more relevant ordering criteria exist (here putting
the two BF16 and the two PH ones each next to one another might be
another option, to make it easier to see their similarity).
Also like said for an earlier patch - please send new versions as new
mails and please avoid sending patches as (only) attachments. See my
earlier reply for why that is.
Jan
More information about the Binutils
mailing list