[PATCH 05/40] cpu/cris: Add u-stall virtual unit to CRIS v32

[Hans-Peter Nilsson]

On Thu, 20 Oct 2022, Tsukasa OI via Binutils wrote:

> Because CRIS v32 model does not define u-stall virtual unit, CGEN-generated
> sim/cris/decodev32.h does not define the function declaration of
> crisv32f_model_crisv32_u_stall.
> 
> It led to a hack in commit 4e6e8ba7c565 ("sim: cris: clean up missing func
> prototype warnings"), manually adding the declaration of
> crisv32f_model_crisv32_u_stall.
> 
> To **not** touch CGEN-generated files manually, this commit adds u-stall
> virtual unit for CRIS v32 to let CGEN generate the function declaration of
> crisv32f_model_crisv32_u_stall automatically.
> 
> This is still hackish but less than the previous one.

Why "hackish"?  You mean cgen should not hork on not 
all models defining all the same units even if unused?

> cpu/ChangeLog:
> 
> 	* cris.cpu: Add u-stall virtual unit to CRIS v32.

Ok, thanks, with or without a comment above it saying "This unit 
is not used in CRIS v32 but needs to be defined for CGEN".

brgds, H-P