[PATCH v3 7/7] x86: move bad-use-of-TLS-reloc check
Jan Beulich
jbeulich@suse.com
Wed Oct 12 07:13:09 GMT 2022
On 11.10.2022 19:57, H.J. Lu wrote:
> On Wed, Oct 5, 2022 at 12:25 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> Having it in match_template() is unhelpful. Neither does looking for the
>> next template to possibly match make any sense in that case, nor is the
>> resulting diagnostic making clear what the problem is.
>>
>> While moving the check, also generalize it to include all SIMD and VEX-
>> encoded insns. This way an existing conditional can be re-used in
>> md_assemble(). Note though that this still leaves a lof of insns which
>> are also wrong to use with these relocations.
>
> These TLS instruction sequences are generated by compilers.
> The check is only meant to check for invalid master registers.
The sequence involving a mask register was generated (aiui) by mistake.
Why would it not be possible to see another similar mistake involve an
XMM register, with a legacy, VEX-, or EVEX-encoded insn?
Anyway - thanks for approving the patch.
Jan
More information about the Binutils
mailing list