[PATCH] ld: Fix segfault in populate_publics_stream
Jan Beulich
jbeulich@suse.com
Wed Nov 30 07:00:52 GMT 2022
On 29.11.2022 18:47, Mark Harmstone wrote:
> > it ... should actually be accompanied by a code comment.
>
> Not really, as it was a straightforward mistake in my original patch. If I'd
> included a NULL check to begin with, I doubt anyone would have batted an
> eyelid.
Maybe. Depends on how close a review would have been done.
> I could have easily worked around this in my test, either by adding in a dummy
> section or by using the preprocessor rather than .equ, but figured that any
> way of causing a segfault is a bug that needs to be fixed.
Of course.
Jan
More information about the Binutils
mailing list