[PATCH] ld: Generate PDB string table

Jan Beulich jbeulich@suse.com
Thu Nov 24 07:24:48 GMT 2022


On 24.11.2022 04:40, Mark Harmstone wrote:
> ---

A little bit of a description would be nice in almost every patch.
Beyond that just one remark for the moment (I may be able to get to
this later):

> +/* Return the hash of an entry in the string table.  */
> +static hashval_t
> +hash_string_table_entry (const void * p)
> +{
> +  struct string *s = (struct string *) p;

Whenever possible please avoid casting away const (or modifiers in
general). Here I don't see a need for a cast in the first place:
"const void *" converts find to "const struct ... *" in C.

Jan


More information about the Binutils mailing list