aarch64-pe can't fill 16 bytes in section .text

[zac.walker@linaro.org]

Patch merged just now. (Was a holiday here yesterday)

I am still investigating another alignment problem so might be another follow up patch. This code from OpenBLAS:

data_ar:
 .word 0x3e44fae6
data_ai:
 .word 0x3d320fa2
start:
 ldr s20, data_ar
 ldr s21, data_ai 

Produces:

zscal-min.s:2: Warning: value 0x3e44fae6 truncated to 0xfae6
zscal-min.s:4: Warning: value 0x3d320fa2 truncated to 0xfa2
zscal-min.s:7: Error: pc-relative load offset not word aligned

Works ok with clang. I am not sure if .word data should be aligned by default in gas or this is just a difference in behaviour.

Thanks,
Zac

-----Original Message-----
From: Alan Modra <amodra@gmail.com> 
Sent: 17 November 2022 04:02
To: Zac Walker <zac.walker@linaro.org>
Cc: Nick Clifton <nickc@redhat.com>; binutils@sourceware.org
Subject: Re: aarch64-pe can't fill 16 bytes in section .text

On Wed, Nov 16, 2022 at 06:03:56PM +0100, Zac Walker wrote:
> Thanks Alan,
> 
> Do you think my SUB_SEGMENT_ALIGN patch is still needed. I didn't merge it yet because I wanted to do more testing with your fix.

Huh, I thought it had already gone in, but it was just in my local tree.

Your patch isn't needed with my fix to obj-coff.c, but it wouldn't be a bad idea to apply it anyway.  We have a few too many places
doing section padding.  It would be nice to get rid of the alignment code in coff_frob_section.

--
Alan Modra
Australia Development Lab, IBM