[PATCH 2/2] x86: break gas dependency on libopcodes

Jan Beulich jbeulich@suse.com
Thu Nov 17 16:59:50 GMT 2022


On 17.11.2022 17:55, H.J. Lu wrote:
> On Thu, Nov 17, 2022 at 8:53 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 17.11.2022 17:48, H.J. Lu wrote:
>>> On Thu, Nov 17, 2022 at 5:29 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>> --- a/gas/configure.ac
>>>> +++ b/gas/configure.ac
>>>> @@ -420,7 +420,7 @@ changequote([,])dnl
>>>>
>>>>      # Do we need the opcodes library?
>>>>      case ${cpu_type} in
>>>> -      vax | tic30)
>>>> +      vax | tic30 | i386)
>>>>         ;;
>>>
>>> This change isn't needed to move i386_seg_prefixes to gas.
>>
>> Correct, but it is needed to fulfill the purpose of the patch as per
>> its title. Otherwise an unused NEEDED entry remains in gas'es .dynamic.
> 
> This patch should be a standalone patch.

I'll split, but I'm nevertheless curious as to why: With it in a separate
patch, there'll be an intermediate bogus state - gas will require
libopcodes.so for no reason. Personally I'd consider such a (minor) bug.

Jan


More information about the Binutils mailing list