[PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32

Michael Matz matz@suse.de
Thu Nov 17 13:21:24 GMT 2022


Hello,

On Thu, 17 Nov 2022, Mike Frysinger wrote:

> > No.  I'm claiming that moving to gnulib is work (even if perhaps not 
> > much?) and change and I (personally) don't see the need to invest into 
> > that work and deal with the change.  Had you asked "should I look into 
> > using gnulib in bfd" my answer would have been "well, try it, why not?".  
> > But you asked "should _we_ look" (aka should someone do that), hence my 
> > answer was in the line of "perhaps, but why bother?".
> 
> you're proposing adding a not insignificant amount of custom portability 
> logic

I'm not proposing anything, but I guess I consider the amount of 
portability code to be actually insignificant in this case.

> and making the readelf code harder to understand & maintain while 
> also not fixing the same bug in other binutils/ tools.  it is perfectly 
> reasonable to ask you to not add tech debt & make the code base worse 
> off for everyone else to maintain, and instead focus on a common 
> solution that the GNU project is already heavily invested in.  this is, 
> of course, the "GNU Binutils" project.

Yeah, well, until someone does the work I guess we'll never know.


Ciao,
Michael.


More information about the Binutils mailing list