[PATCH] readelf: use fseeko for elf files >= 2 GiB on x86_64-mingw32

[Jose E. Marchesi]

> [... snip ...]
>> I think "growing" and "lot of" don't describe the effort.  Rewriting to 
>> use gnulib (and the corresponding necessary testing) might be trivial as 
>> well (though I don't think so), but the returns are still very small.
>
> i disagree with your assessment.  the patch proposed isn't exactly trivial,
> nor is it widely tested like gnulib.
>
> further, if you read the existing binutils/configure.ac, there's a lot of
> "copied from gnulib" logic in there that would get cleaned up.  there's
> also logic for old systems that i doubt aren't actively tested (e.g. who
> is actually building on Next 3.2?).
>
> even further, readelf isn't the only file under binutils/ that uses fseek,
> but it seems to be the only program you're trying to fix.  so the others
> are still broken, which wouldn't be the case if gnulib was used.
>
> even even further, gnulib is already in the tree.  it isn't like you have
> to import & integrate its build logic or manage its autotool logic or its
> header paths.  there are 3 top-level projects using it now, one of which
> i converted, and it was pretty trivial.

FWIW, we are considering making BFD to import a gnulib module with the
sframe encoders and decoders (we already submitted the new module to
bug-gnulib and it is under review) rather than having to maintain a
separated libsframe in the tree.

I also agree with Mike in that using gnulib in bfd would bring many
other advantages...