gprofng patch to review
Vladimir Mezentsev
vladimir.mezentsev@oracle.com
Mon Nov 14 18:38:01 GMT 2022
Hello Markus,
On 11/14/22 03:22, Metzger, Markus T wrote:
>> +#ifdef DBG_LT1
>> TprintfT (DBG_LT1, "my_cpuid: __get_cpuid(0x%x, 0x%x, 0x%x, 0x%x,
>> 0x%x) returns %d\n",
>> op, regs->eax, regs->ebx, regs->ecx, regs->edx, ret);
>> +#endif
>>
>>
>>
>> I suggest to just remove TprintfT. This debug output is currently not
>> used by anyone.
> There are other Tprintf (no trailing T) in the ARM part. I didn't touch those
> as it didn't fail on my box and I wouldn't be able to test the changes.
>
> Do you want me to remove those, too? Untested.
yes. Please remove those too.
Your Arm build will fail if you use this file.
Thank you,
-Vladimir
More information about the Binutils
mailing list