[PATCH V2] GAS fix alignment for aarch64-pe

Zac Walker zac.walker@linaro.org
Mon Nov 14 17:24:23 GMT 2022


For the aarch64-pe target various values of '.align' causes writing of COFF files to fail.

This version of the patch differs from the first by using the write.c implementation of SUB_SEGMENT_ALIGN. This means there was no need to modify md_section_align or aarch64_handle_align. The change is specific to the aarch64-pe target.

In my testing generated aligned code was correctly padded with nop.

Thanks,

Zac


---
  gas/config/tc-aarch64.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h
index 2d514ff610..0ea73021f2 100644
--- a/gas/config/tc-aarch64.h
+++ b/gas/config/tc-aarch64.h
@@ -191,7 +191,10 @@ struct aarch64_frag_type
        goto LABEL;								\
      }

+/* COFF sub section alignment calculated using the write.c implementation.  */
+#ifndef OBJ_COFF
  #define SUB_SEGMENT_ALIGN(SEG, FRCHAIN) 0
+#endif

  #define DWARF2_LINE_MIN_INSN_LENGTH 	4

-- 
2.25.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-GAS-fix-alignment-for-aarch64-pe.patch
Type: text/x-diff
Size: 719 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20221114/68a99e0a/attachment.bin>


More information about the Binutils mailing list