[PATCH] GAS fix section alignment for aarch64-pe

Alan Modra amodra@gmail.com
Mon Nov 7 22:58:05 GMT 2022


On Mon, Nov 07, 2022 at 06:53:35PM +0100, Zac Walker via Binutils wrote:
> For the aarch64-pe target, section alignment for various values of
> '.align'  causes writing of coff files to fail.
> This patch performs aligning in md_section_align as opposed to the
> original approach in aarch64_handle_align. The change is specific to
> the aarch64-pe target.

This can't be correct since HANDLE_ALIGN and md_section_align perform
quite different functions.  I don't think you should be changing
aarch64_handle_align.  For example:

 .text
 .p2align 4
 nop
 .p2align 3
 nop

The second p2align needs to continue emitting nops.

(Also, please fix your email client to *not* format lines.  Wrapping
lines and changing white space breaks patches.)

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list