[COMMITTED] PowerPC: Add support for RFC02653 - Dense Math Facility

Tom de Vries tdevries@suse.de
Wed Nov 2 18:41:51 GMT 2022


On 11/2/22 19:32, Peter Bergner wrote:
> On 11/2/22 1:27 PM, Tom de Vries wrote:
>>> +{"pmdmxvbf16ger2",PMMIRR|XX3(59,51),   P_GER2_MASK,    POWER10, 0,    {ACC, XA6a, XB6a, XMSK, YMSK, PMSK2}},
>>>   {"pmxvbf16ger2",  PMMIRR|XX3(59,51),   P_GER2_MASK,    POWER10, 0,    {ACC, XA6a, XB6a, XMSK, YMSK, PMSK2}},
>>
>> Hi,
>>
>> I noticed a regression in a gdb test-case:
>> ...
>> FAIL: gdb.arch/powerpc-power10.exp: found: pmxvbf16ger2 a4,vs0,vs1,0,0,0
>> ...
>> and I suspect it's because of this commit.
>>
>>
>> The disassembly shows:
>> ...
>>     0x000000000000063c <+1596>:  pmdmxvbf16ger2 a4,vs0,vs1,0,0,0^M
>> ...
>> while the test expects pmxvbf16ger2.
> 
> Yes, Carl notified me of the fallout.  I gave him a patch that updates
> the expected output to look for the new name.  Carl has agreed to
> shepherd the patch to fix the fallout.

Could someone explain why that is the right solution?

I don't see any dm<n> registers in the instruction "pmxvbf16ger2 
a4,vs0,vs1,0,0,0".

Why then should the pmdmxvbf16ger2 name be used?

Thanks,
- Tom


More information about the Binutils mailing list