[PATCH,V3 11/15] libctf: add libsframe to LDFLAGS and LIBS

[Nick Alcock]

On 31 Oct 2022, Indu Bhagat spake thusly:

> On 10/30/22 06:27, Mike Frysinger wrote:
>> On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote:
>>> --- a/libctf/configure.ac
>>> +++ b/libctf/configure.ac
>>>
>>> -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
>>> +LDFLAGS="-L../bfd -L../libiberty -L../libsframe/.libs/ $ZLIBDIR $LDFLAGS"
>> libbfd is using libtool which generates libbfd.la which should contain the
>> libsframe linking info, so do you really need this manual -L ?  and if you
>> really do, doesn't -L../libsframe suffice ?
>> 
>>> -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
>>> +LIBS="-lbfd -liberty -lz -lsframe $ZSTD_LIBS $intl $LIBS"
>> similarly here, the libbfd->libsframe dependency should be tracked by the
>> libtool linker script ...
>
> For this specific link in libctf/configure.ac for checking ELF support in BFD, libtool is not being used.

Agreed. I always found this a bit of a drag, but libtool is *generated
by* configure so there's not really much we can do.

-- 
NULL && (void)