[PATCH] x86/Intel: test non-legacy VCVT{,U}SI2SH insn forms

[Cui, Lili]

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Thursday, May 19, 2022 1:54 PM
> To: Cui, Lili <lili.cui@intel.com>
> Cc: Binutils <binutils@sourceware.org>; H.J. Lu <hjl.tools@gmail.com>
> Subject: Re: [PATCH] x86/Intel: test non-legacy VCVT{,U}SI2SH insn forms
> 
> On 19.05.2022 03:21, Cui, Lili wrote:
> >>> For an unclear reason corresponding AVX512F tests were apparently
> >>> not cloned or used as reference here, and instead the bogus legacy
> >>> forms of the insns (with the embedded rounding specifier not last) were
> used.
> >>> ---
> >>> Ideally the legacy forms wouldn't have been supported by gas in the
> >>> first place, but I guess it's too late now for correcting this mistake.
> >>>
> >>> Note that in some other (pre-FP16) tests we also have some legacy
> >>> instances left. Perhaps we want to retain those for making sure they
> >>> continue to work even if modern code better wouldn't use them.
> >>> Ultimately even those forms aren't MASM-compatible, but I'll get to
> >>> that later.
> >>>
> >
> > Hi Jan, I also found some other similar cases, and I will create a patch to fix
> them later. Thanks!
> 
> I'm not sure we want to eliminate / replace all of them - see what I've said
> above. After all we want the assembler to continue to accept this form, for
> not breaking code pre-dating the introduction of the partly (and now also the
> fully) SDM-compatible form.
> 
Ok, got it, I'm not going to change them to make sure their formatting continues to work.

Thanks,
Lili.

> Jan
>