[PATCH 2/6] gas: simplify ignore_input()
Jan Beulich
jbeulich@suse.com
Fri May 6 06:06:08 GMT 2022
First of all convert to switch(), in preparation of adding another
directive here which may not be ignored. While doing so drop dead code:
A string the first two characters of which do not match "if" also wont
match "ifdef" or "ifndef".
---
I was tempted to drop the leading 'e' from the strings compared against,
but I then decided against because doing so might not be liked by
everyone.
--- a/gas/cond.c
+++ b/gas/cond.c
@@ -513,17 +513,19 @@ ignore_input (void)
}
/* We cannot ignore certain pseudo ops. */
- if (((s[0] == 'i'
- || s[0] == 'I')
- && (!strncasecmp (s, "if", 2)
- || !strncasecmp (s, "ifdef", 5)
- || !strncasecmp (s, "ifndef", 6)))
- || ((s[0] == 'e'
- || s[0] == 'E')
- && (!strncasecmp (s, "else", 4)
- || !strncasecmp (s, "endif", 5)
- || !strncasecmp (s, "endc", 4))))
- return 0;
+ switch (s[0])
+ {
+ case 'i': case 'I':
+ if (s[1] == 'f' || s[1] == 'F')
+ return 0;
+ break;
+ case 'e': case 'E':
+ if (!strncasecmp (s, "else", 4)
+ || !strncasecmp (s, "endif", 5)
+ || !strncasecmp (s, "endc", 4))
+ return 0;
+ break;
+ }
return (current_cframe != NULL) && (current_cframe->ignoring);
}
More information about the Binutils
mailing list