gas: set_symtab()'s setting of BSF_KEEP

[Alan Modra]

On Wed, May 04, 2022 at 10:54:25AM +0200, Jan Beulich wrote:
> Alan,
> 
> while looking into how to address an Arm64 regression I ended up
> coming across this code, originating from commit 76d129399558. The
> first thing that puzzled me was the != for checking BSF_SECTION_SYM.

The test is to prevent any attempt to change the const global_syms[].
That's why flags != BSF_SECTION_SYM is quite OK.  It would be cleaner
to write a bfd_is_const_symbol similar to bfd_is_const_section.

-- 
Alan Modra
Australia Development Lab, IBM