[PATCH 4/4] gas/Dwarf5: re-use file 0 line string table entry when faking file 0

Jan Beulich jbeulich@suse.com
Tue Mar 22 10:45:49 GMT 2022


No need to emit the same string a 2nd time for file 1 in this case.
---
An alternative might be to, just like is already the case for
directories, pull file 0 handling out of the loop.

--- a/gas/dwarf2dbg.c
+++ b/gas/dwarf2dbg.c
@@ -2137,7 +2137,7 @@ out_dir_and_file_list (segT line_seg, in
   bool emit_timestamps = true;
   bool emit_filesize = true;
   segT line_str_seg = NULL;
-  symbolS *line_strp;
+  symbolS *line_strp, *file0_strp = NULL;
 
   /* Output the Directory Table.  */
   if (DWARF2_LINE_VERSION >= 5)
@@ -2301,9 +2301,17 @@ out_dir_and_file_list (segT line_seg, in
 	}
       else
 	{
-	  line_strp = add_line_strp (line_str_seg, fullfilename);
+	  if (!file0_strp)
+	    line_strp = add_line_strp (line_str_seg, fullfilename);
+	  else
+	    line_strp = file0_strp;
 	  subseg_set (line_seg, 0);
 	  TC_DWARF2_EMIT_OFFSET (line_strp, sizeof_offset);
+	  if (i == 0 && files_in_use > 1
+	      && files[0].filename == files[1].filename)
+	    file0_strp = line_strp;
+	  else
+	    file0_strp = NULL;
 	}
 
       /* Directory number.  */



More information about the Binutils mailing list