[PATCH 1/3] gprofng: Define ATTRIBUTE_FALLTHROUGH

[Jose E. Marchesi]

> Define ATTRIBUTE_FALLTHROUGH to __attribute__ ((fallthrough)) only for
> GCC 7 or above.
>
> 	PR gprof/28969
> 	* common/gp-defs.h (ATTRIBUTE_FALLTHROUGH): New.
> 	* src/gp-collect-app.cc (collect::check_args): Replace
> 	__attribute__ ((fallthrough)) with ATTRIBUTE_FALLTHROUGH.

Oh sorry HJ I just pushed the patch below as obvious because I couldn't
build gprofng with GCC 6.  Didnt see your patch here which is better.

commit 6aa03e9c1769c8d925f4d23d72af93483bfd31f3
Author: Jose E. Marchesi <jose.marchesi@oracle.com>
Date:   Tue Mar 15 21:04:57 2022 +0100

    gprofng: avoid using `fallthrough' attributes
    
    gprofng didn't build with gcc 6.3 due to the usage of __attribute__
    ((fallthrough)).  This patch uses /* FALLTHROUGH */ instead.
    
    2022-03-15  Jose E. Marchesi  <jose.marchesi@oracle.com>
    
            * gprofng/src/gp-collect-app.cc (collect::check_args): Use
            fallthrough comment instead of attribute.

diff --git a/ChangeLog b/ChangeLog
index 73b6085d6ef..dfe468c0af4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2022-03-15  Jose E. Marchesi  <jose.marchesi@oracle.com>
+
+	* gprofng/src/gp-collect-app.cc (collect::check_args): Use
+	fallthrough comment instead of attribute.
+
 2022-03-11  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
 
 	* Makefile.def: Add gprofng module.
diff --git a/gprofng/src/gp-collect-app.cc b/gprofng/src/gp-collect-app.cc
index afaae70bc2b..a40cf8fb9be 100644
--- a/gprofng/src/gp-collect-app.cc
+++ b/gprofng/src/gp-collect-app.cc
@@ -848,7 +848,7 @@ collect::check_args (int argc, char *argv[])
 	  }
 	case 'O':
 	  overwriteExp = true;
-	  __attribute__ ((fallthrough));
+          /* FALLTHROUGH */
 	case 'o':
 	  if (precheck == 1)
 	    {