[PATCH] MIPS/opcodes: Fix alias annotation for negate instructions
Sagar Patel
sagarmp@cs.unc.edu
Tue Mar 8 06:25:47 GMT 2022
On Mon, Mar 7, 2022 at 3:46 PM Maciej W. Rozycki <macro@orcam.me.uk> wrote:
> On Mon, 7 Mar 2022, Sagar Patel wrote:
> Please do not include updates to ChangeLog files with the diff as they
> will almost surely cause a conflict right away. Instead please just put
> entries intended for ChangeLog files within the change description, as you
> correctly did, and then the committer will produce actual ChangeLog file
> entries from that text.
Oh, that makes way more sense. I'll drop the changes to the ChangeLog files.
> This might be overly pedantic, but with any test case I suggest putting
> the absolute minimum there so as not to make someone in the future wonder
> what the specific requirement was for one option or another (possibly I
> shouldn't have used `.set noat' and $1 either, but let's leave it as it
> is).
I agree. I can remove the use of `.set noat' in the two new test
sources. Should I do that?
> It looks perfect otherwise and once your paperwork has been sorted I will
> push either your change as posted with amendments made for the two pieces
> above or any v2 if you prefer to make one yourself.
Just to keep you in the loop, I sent in the request for the paperwork.
I'll let you know if I don't hear back soon.
I'll send a v2 with the requested changes. Thank you for the review.
---Sagar Patel
More information about the Binutils
mailing list