[PATCH] x86: drop print_operand_value()'s "hex" parameter

Michael Matz matz@suse.de
Wed Jun 15 15:07:04 GMT 2022


Hey,

On Tue, 14 Jun 2022, Jan Beulich via Binutils wrote:

> For quite some  time all callers have been passing 1 / true. While there
> fold the final oappend_with_style() calls.
> ---
> Instead of 0x%x I could see us using %#x, thus printing at least zero
> without the redundant 0x prefix. Thoughts?

As you're asking for opinions, here's mine: in this case I think 
consistency is better, I think there's no obvious reason to print
  0 but 0xa (for instance)
and not
  0x0 and 0xa
Sure, it's redundant, but IMHO that doesn't trump consistency.


Ciao,
Michael.


More information about the Binutils mailing list