[PATCHv3] libopcodes: extend the styling within the i386 disassembler

Jan Beulich jbeulich@suse.com
Fri Jun 10 10:56:06 GMT 2022


On 27.05.2022 19:44, Andrew Burgess via Binutils wrote:
> @@ -11595,11 +11750,15 @@ OP_E_memory (instr_info *ins, int bytemode, int sizeflag)
>  	      print_displacement (ins, ins->scratchbuf, disp);
>  	    else
>  	      print_operand_value (ins, ins->scratchbuf, 1, disp);
> -	    oappend (ins, ins->scratchbuf);
> +	    oappend_with_style (ins, ins->scratchbuf,
> +				dis_style_address_offset);

Is there a reason you changed this to dis_style_address_offset, but
not the other cases where print_displacement() is used (always for
similar purposes)? I'm asking because I'm going to touch all these
instances, so if dis_style_address_offset was always meant to be
used there, I'd switch that around kind of as a side effect.

Jan


More information about the Binutils mailing list