[PATCH] bfd: Properly install library and header files

[Mike Frysinger]

On 23 Jan 2022 07:36, H.J. Lu via Binutils wrote:
> Rename bfdlib_LTLIBRARIES and bfdinclude_HEADERS to lib_LTLIBRARIES and
> include_HEADERS to fix the missing installed library and header files in
> bfd caused by

your patch below does two things: renames the vars and deletes an install
target.  pretty sure only the latter is necessary to fix things.  although
i don't know the history behind why bfd uses these names.

> --- a/bfd/Makefile.am
> +++ b/bfd/Makefile.am
> @@ -36,14 +36,14 @@ libbfd_la_LDFLAGS =
>  if INSTALL_LIBBFD
>  bfdlibdir = @bfdlibdir@
>  bfdincludedir = @bfdincludedir@
> -bfdlib_LTLIBRARIES = libbfd.la
> -bfdinclude_HEADERS = $(BFD_H) $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \
> -		     $(INCDIR)/diagnostics.h $(INCDIR)/bfdlink.h
> +lib_LTLIBRARIES = libbfd.la
> +include_HEADERS = $(BFD_H) $(INCDIR)/ansidecl.h $(INCDIR)/symcat.h \
> +		  $(INCDIR)/diagnostics.h $(INCDIR)/bfdlink.h
>  else !INSTALL_LIBBFD
>  # Empty these so that the respective installation directories will not be created.
>  bfdlibdir =
>  bfdincludedir =
> -bfdinclude_HEADERS =
> +include_HEADERS =
>  rpath_bfdlibdir = @bfdlibdir@
>  noinst_LTLIBRARIES = libbfd.la
>  libbfd_la_LDFLAGS += -rpath $(rpath_bfdlibdir)

there's stale comments in here now, as well as unused vars.  the only reason
bfdincludedir was defined was because bfdinclude_HEADERS was too.

i think you should revert the bfd/Makefile.am changes and only keep the fix
to doc/local.mk.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20220123/4061f336/attachment.sig>