Building 2.37 fails on bool errors

[Jan Beulich]

On 14.01.2022 03:59, NightStrike via Binutils wrote:
> On CentOS 7 with a host gcc of 4.8.5, configuring and building
> binutils 2.36.1 with --disable-nls and --prefix as configure options
> works fine.  When I use the same configure options on 2.37, I get
> errors from dis-asm.h and dis-asm.c that "bool" is undeclared.  Adding
> "#include <stdbool.h> to dis-asm.h fixes the build problem, and it
> completes.

I find this report odd: For one I can't find any dis-asm.c in the repo.
And then dis-asm.h includes bfd.h, which unconditionally includes
stdbool.h. That inclusion isn't first, but aiui the errors you
observe are in dis-asm.h, not in one of the other headers bfd.h
includes earlier. Did you use plain upstream 2.37, or are there any
extra patches in place which could cause the issue?

There's no surprise that the same isn't the case on 2.36.1, as the
conversion to bool did happen only afterwards.

Jan