2.38 branch date approaching

[Alan Modra]

On Mon, Jan 10, 2022 at 08:20:13AM -0800, H.J. Lu via Binutils wrote:
> Hi Nick,
> 
> Can you review my DT_RELR patches?
> 
> https://sourceware.org/pipermail/binutils/2022-January/119222.html

I've looked over them.  I keep asking myself, "Why did HJ have to
reinvent everything rather than reuse existing code used in other
targets?"  And "Why do we need yet another hook?"  All of which will
be a maintenance burden, especially after you retire or quit binutils
work for any other reason.

You'll need to justify design decisions, and not assume other targets
will follow your design.  This sort of thing

+  /* NB: Also enable relaxation to layout sections for DT_RELR.  */
+  if (RELAXATION_ENABLED || link_info.enable_dt_relr)

is just wrong.  There is absolutely no fundamental reason that
bfd_relax_section must handle sizing of the DT_RELR section.  I choose
to not do so on powerpc64.

-- 
Alan Modra
Australia Development Lab, IBM