[PATCH v4 2/3] RISC-V: Scalar crypto instructions and operand set

[Jan Beulich]

On 04.01.2022 09:38, 陈嘉炜 wrote:
> > -----原始邮件-----
> > 发件人: "Jan Beulich" <jbeulich@suse.com>
> > 发送时间: 2022-01-04 16:04:31 (星期二)
> > 收件人: jiawei <jiawei@iscas.ac.cn>
> > 抄送: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, binutils@sourceware.org
> > 主题: Re: [PATCH v4 2/3] RISC-V: Scalar crypto instructions and operand set
> > 
> > On 15.11.2021 04:03, jiawei wrote:
> > > @@ -847,6 +856,49 @@ const struct riscv_opcode riscv_opcodes[] =
> > >  {"bext",      0, INSN_CLASS_ZBS,   "d,s,t",  MATCH_BEXT, MASK_BEXT, match_opcode, 0 },
> > >  {"bext",      0, INSN_CLASS_ZBS,   "d,s,>",  MATCH_BEXTI, MASK_BEXTI, match_opcode, INSN_ALIAS },
> > >  
> > > +/* Zbkx instructions  */
> > > +{"xperm4",     0, INSN_CLASS_ZBKX,  "d,s,t",  MATCH_XPERM4, MASK_XPERM4, match_opcode, 0 },
> > > +{"xperm8",     0, INSN_CLASS_ZBKX,  "d,s,t",  MATCH_XPERM8, MASK_XPERM8, match_opcode, 0 },
> > > +
> > > +/* Zknd instructions  */
> > > +{"aes32dsi",  32, INSN_CLASS_ZKND,  "d,s,t,y",  MATCH_AES32DSI, MASK_AES32DSI, match_opcode, 0 },
> > > +{"aes32dsmi", 32, INSN_CLASS_ZKND,  "d,s,t,y",  MATCH_AES32DSMI, MASK_AES32DSMI, match_opcode, 0 },
> > 
> > For these two and a few more with immediate operands and a trailing 'i'
> > in the mnemonics: Shouldn't they have i-suffix-less pseudos, matching
> > other insns with immediate operands?
> > 
> > Jan
> 
> I think the 'i' trailing is just a dinstinguishing symbol in zknd extension, there are no i-suffix-less pseudo definitions in the cryptogrpah extension spec, please check it.

Perhaps I should have said explicitly that this is a question not so much
on the implementation, but on the spec itself.

Jan