[PATCH 1/5] Fix size of external_reloc for pe-aarch64

[Jan Beulich]

On 20.12.2022 13:59, Mark Harmstone wrote:
> On 16/12/22 10:47, Tamar Christina wrote:
>>
>> The code was taken from the Arm port which weirdly had a different size
>> for this whether it was a WINCE target or not.  For WINCE target it has 10, but for
>> everything else 14 (See include/coff/arm.h).   Since I didn't have relocations
>> support anyway (the original intention was only to support objcopy workflow)
>> I didn't dig too deeply into why Arm has it as 14 and the extra field.
>>
>> That said 10 looks to be the correct value.
>>
>> Thanks,
>> Tamar
> 
> Thanks Tamar. Sorry, I should have copied you in in the first place.
> 
> I can't remember the specifics, but I definitely needed this patch to get EXEs working on Windows.

But EXEs don't use this kind of relocation; the base relocations (fixups)
used there are encoded in an entirely different way. The relocs here should
matter for are COFF object files only.

Jan