[PATCH v2] bfd: Discard region regardless of warning flag

Alan Modra amodra@gmail.com
Mon Dec 19 22:59:47 GMT 2022


On Mon, Dec 19, 2022 at 07:34:51PM +0100, Torbjörn SVENSSON via Binutils wrote:
> v1 -> v2:
> Added testcase
> 
> Ok for trunk?

This is OK except for a few minor things.

> I have commit access for GDB. Do I still need someone to push this for
> me or do I automatically have write access to the complete binutils
> repository and just need the approval to push it myself?

You should be able to push it.

> The discard of the region should be performed regardless if the warning

This should say "The discard of symbols in..." not "The discard of...".
The code here is handling symbols.

> for the discard is enabled or not.

> +++ b/ld/testsuite/ld-arm/non-contiguous-arm7.d
> @@ -0,0 +1,4 @@
> +#name: non-contiguous-arm7
> +#source: non-contiguous-arm7.s
> +#ld: --enable-non-contiguous-regions -T non-contiguous-arm7.ld --gc-sections

Please remove --gc-sections.  The testcase doesn't need it.

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list