[PATCH v2 3/6] LoongArch: opcodes: Add support for linker relaxation.

Hans-Peter Nilsson hp@bitrange.com
Wed Dec 14 19:21:46 GMT 2022


On Tue, 13 Dec 2022, mengqinggang wrote:

> Set gas default to enable relax.
> 
> opcodes/ChangeLog:
> 
> 	* loongarch-opc.c (struct loongarch_ASEs_option): New member relax and
> 	  the default value is 1.

Not that ChangeLog entries are required anymore, but seeing this 
consistent formatting error hurts my nits.  Here and the rest of 
your patches:

ChangeLog continuation lines line up with a TAB character to the 
"*" on the first line, not the text on that line.  Like so:

<TAB>* loongarch-opc.c (struct ...
<TAB>the default value ...

See existing ChangeLog entries.

Also, now that I can take my eyes away from the error, I think 
it's "New member relax with the default value 1" but I guess 
that's more up to poetic freedom.

brgds, H-P


More information about the Binutils mailing list