[PATCH 1/2] libctf: remove unnecessary zlib constructs

[Indu Bhagat]

On 12/9/22 17:07, Mike Frysinger wrote:
> On 09 Dec 2022 12:21, Indu Bhagat via Binutils wrote:
>> -ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'`
>> -LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS"
>> +LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
> 
> $ZLIBDIR is zlib related ...
> 
>> -LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS"
>> +LIBS="-lbfd -liberty $intl $LIBS"
> 
> ... but $ZSTD_LIBS is zstd related, not zlib.
> 
> commit message only says zlib.
> 

Oops, yes, the removal of $ZSTD_LIBS was unintentional.

> also, you're still calling AM_ZLIB & AC_ZSTD which should be removed.
> -mike

AM_ZLIB cannot be removed at this time from libctf/configure.ac. There 
was a discussion earlier on this matter in context of using libtool and 
GDB: https://sourceware.org/pipermail/gdb-patches/2022-November/193771.html

Regarding removal of AC_ZSTD, perhaps, yes. I will run some tests and 
send a separate patch.

Thanks!