[PATCH] x86: Remove unnecessary vex.w check for xh_mode in disassembler

Jan Beulich jbeulich@suse.com
Tue Dec 6 07:29:33 GMT 2022


On 06.12.2022 02:36, Jiang, Haochen wrote:
>>> Another reason for removing this check is because xh_mode with
>>> broadcast usage should not indicate the vex.w bit. Instead it should
>>> be handled by a W table entry.
>>
>> There are no broadcast insns using xh_mode, and you can't really mean
>> embedded broadcast (because EVEX.W needs to be properly encoded
>> there).
>> Hence I don't follow what you're talking about here.
> 
> Maybe this part is a little misleading. I will delete that in commit message.
> What I actually mean is just like what you commented.
> 
> I suppose using a W table entry in the future to encode here if not using
> something like %XH.

Feel free to commit with that text dropped; aiui you've addressed H.J.'s
question.

Jan


More information about the Binutils mailing list