[PATCH v4] ld: Make archive member file extension comparisons case insensitive when cross compiling too

Martin Storsjö martin@martin.st
Thu Aug 25 06:53:25 GMT 2022


On Wed, 24 Aug 2022, Nick Clifton wrote:

>> +/* A case insensitive comparison, regardless of the host platform, used 
>> for
>> +   comparing file extensions. Parameter s1 points at the extension in a 
>> file
>> +   name (pointing at the starting '.'). Parameter s2 is a lower case 
>> string
>> +   without the leading '.'. */
>
> Comment formatting: two spaces before the closing */
>
>> +static int fileext_cmp (const char *s1, const char *s2)
>
> Function name formatting - name on a separate line from the return type.
>
> And yes, I know that the same problem exists for the is_underscoring()
> function directly before this one.  A patch to fix that formatting is
> pre-approved. :-)

I pushed a patch that fixes this aspect now as well, for consistency.

// Martin



More information about the Binutils mailing list