[PATCH] x86: Ignore protected visibility in shared libraries on Solaris

[H.J. Lu]

On Tue, Aug 23, 2022 at 6:41 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Wed, Aug 24, 2022 at 09:46:32AM +0930, Alan Modra wrote:
> > On Tue, Aug 23, 2022 at 10:34:32AM -0700, H.J. Lu via Binutils wrote:
> > > On x86, the PLT entry in executable may be used as function address for
> > > functions in shared libraries.  If functions are protected, the function
> > > address used in executable can be different from the function address
> > > used in shared library.  This will lead to incorrect run-time behavior
> > > if function pointer equality is needed.  By default, x86 linker issues
> > > an error in this case.
> > >
> > > On Solaris, linker issued an error for
> > >
> > > struct tm *tb = (kind == CPP_time_kind::FIXED ? gmtime : localtime) (&tt);
> > >
> > > where gmtime is a protected function in libc.so.  Use gmtime's PLT entry
> > > in executable as function address is safe since function pointer equality
> > > isn't needed.
> >
> > I'm curious as to how pointer_equality_needed came to be set for
> > gmtime.
>
> Hmm, I figure it was -fno-PIC code with a R_X86_64_32 or R_X86_64_64
> referencing gmtime.  And yes, -fno-PIC -mcmodel=medium will generate
> R_X86_64_32 in a testcase like
>
> extern int f1 (int);
> extern int f2 (int);
> int foo (int what, int val) { return (what ? f1 : f2) (val); }
>
> So why exclude R_X86_64_32 with an ABI_64_P test before setting
> func_pointer_ref in elf_x86_64_scan_relocs?

The whole condition is

                 /* At run-time, R_X86_64_64 can be resolved for both
                     x86-64 and x32. But R_X86_64_32 and R_X86_64_32S
                     can only be resolved for x32.  Function pointer
                     reference doesn't need PLT for pointer equality.  */
                  if ((sec->flags & SEC_READONLY) == 0
                      && (r_type == R_X86_64_64
                          || (!ABI_64_P (abfd)
                              && (r_type == R_X86_64_32
                                  || r_type == R_X86_64_32S))))
                    func_pointer_ref = true;

This is for relocations in data section (not readonly).   The function
pointer reference must use R_X86_64_64 if ABI_64_P is true.

-- 
H.J.