bfd_elf_set_group_contents assertion

Alan Modra amodra@gmail.com
Wed Aug 17 08:00:54 GMT 2022


objcopy of broken SHT_GROUP sections shouldn't write garbage.

	* elf.c (bfd_elf_set_group_contents): If number of entries is
	unexpected, fill out section with zeros.

diff --git a/bfd/elf.c b/bfd/elf.c
index 2e01d7e9a44..35aa45e3b90 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -3614,7 +3614,12 @@ bfd_elf_set_group_contents (bfd *abfd, asection *sec, void *failedptrarg)
     }
 
   loc -= 4;
-  BFD_ASSERT (loc == sec->contents);
+  if (loc != sec->contents)
+    {
+      BFD_ASSERT (0);
+      memset (sec->contents + 4, 0, loc - sec->contents);
+      loc = sec->contents;
+    }
 
   H_PUT_32 (abfd, sec->flags & SEC_LINK_ONCE ? GRP_COMDAT : 0, loc);
 }

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list